Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the behavior of IM rules and multi-value indicator documents #4326

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Document the behavior of IM rules and multi-value indicator documents #4326

merged 5 commits into from
Dec 6, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Nov 29, 2023 •
edited
Loading

Contributes to #3354.

Preview - inserted a note after step 2e

@nastasha-solomon nastasha-solomon added v8.2.0 v8.3.0 v8.4.0 v8.5.0 v8.6.0 v8.7.0 v8.8.0 v8.9.0 Team: Detection Engine Priority: Low Issues that need attention, but are not urgent v8.10.0 Effort: Medium Issues that take moderate but not substantial time to complete v8.11.0 labels Nov 29, 2023
@nastasha-solomon nastasha-solomon self-assigned this Nov 29, 2023
@github-actions GitHub Actions
Copy link

Documentation previews:

@nastasha-solomon nastasha-solomon marked this pull request as ready for review November 29, 2023 23:56
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner November 29, 2023 23:57
rylnd
rylnd previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are straightforward and LGTM!

docs/detections/rules-ui-create.asciidoc Show resolved Hide resolved
natasha-moore-elastic
natasha-moore-elastic approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@nastasha-solomon nastasha-solomon merged commit ed4d816 into main Dec 6, 2023
4 checks passed
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
@nastasha-solomon @mergify
Document the behavior of IM rules and multi-value indicator documents (…
9443ac6 
…#4326)

(cherry picked from commit ed4d816)
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
@nastasha-solomon @mergify
Document the behavior of IM rules and multi-value indicator documents (…
10d417f 
…#4326)

(cherry picked from commit ed4d816)
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
@nastasha-solomon @mergify
Document the behavior of IM rules and multi-value indicator documents (…
d9b3413 
…#4326)

(cherry picked from commit ed4d816)
This was referenced Dec 6, 2023
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
@nastasha-solomon @mergify
Document the behavior of IM rules and multi-value indicator documents (…
55019de 
…#4326)

(cherry picked from commit ed4d816)
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
@nastasha-solomon @mergify
Document the behavior of IM rules and multi-value indicator documents (…
130f7bb 
…#4326)

(cherry picked from commit ed4d816)
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
@nastasha-solomon @mergify
Document the behavior of IM rules and multi-value indicator documents (…
baaa660 
…#4326)

(cherry picked from commit ed4d816)
This was referenced Dec 6, 2023
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
@nastasha-solomon @mergify
Document the behavior of IM rules and multi-value indicator documents (…
fbfbb0f 
…#4326)

(cherry picked from commit ed4d816)
@mergify mergify bot mentioned this pull request Dec 6, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
@nastasha-solomon @mergify
Document the behavior of IM rules and multi-value indicator documents (…
c84d28f 
…#4326)

(cherry picked from commit ed4d816)

# Conflicts:
#	docs/detections/rules-ui-create.asciidoc
@mergify mergify bot mentioned this pull request Dec 6, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
@nastasha-solomon @mergify
Document the behavior of IM rules and multi-value indicator documents (…
61ce251 
…#4326)

(cherry picked from commit ed4d816)

# Conflicts:
#	docs/detections/rules-ui-create.asciidoc
@mergify mergify bot mentioned this pull request Dec 6, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
@nastasha-solomon @mergify
Document the behavior of IM rules and multi-value indicator documents (…
d4e6e8b 
…#4326)

(cherry picked from commit ed4d816)

# Conflicts:
#	docs/detections/rules-ui-create.asciidoc
@mergify mergify bot mentioned this pull request Dec 6, 2023
Merged
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
@mergify @nastasha-solomon
[8.8] Document the behavior of IM rules and multi-value indicator doc…
4b4fb23 
…uments (backport #4326) (#4399)

Co-authored-by: Nastasha Solomon <[email protected]>
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
@mergify @nastasha-solomon
[8.7] Document the behavior of IM rules and multi-value indicator doc…
c9d0627 
…uments (backport #4326) (#4400)

Co-authored-by: Nastasha Solomon <[email protected]>
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
@mergify @nastasha-solomon
[8.6] Document the behavior of IM rules and multi-value indicator doc…
3f8fc24 
…uments (backport #4326) (#4401)

Co-authored-by: Nastasha Solomon <[email protected]>
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
@mergify @nastasha-solomon
[8.5] Document the behavior of IM rules and multi-value indicator doc…
2548aca 
…uments (backport #4326) (#4402)

Co-authored-by: Nastasha Solomon <[email protected]>
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
@mergify @nastasha-solomon
[8.11] Document the behavior of IM rules and multi-value indicator do…
437f82c 
…cuments (backport #4326) (#4396)

Co-authored-by: Nastasha Solomon <[email protected]>
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
@mergify @nastasha-solomon
[8.10] Document the behavior of IM rules and multi-value indicator do…
6ae4d52 
…cuments (backport #4326) (#4397)

Co-authored-by: Nastasha Solomon <[email protected]>
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
@mergify @nastasha-solomon
[8.9] Document the behavior of IM rules and multi-value indicator doc…
53a6a62 
…uments (backport #4326) (#4398)

Co-authored-by: Nastasha Solomon <[email protected]>
nastasha-solomon added a commit that referenced this pull request Dec 6, 2023
@mergify @nastasha-solomon
[8.4] Document the behavior of IM rules and multi-value indicator doc…
d917034 
…uments (backport #4326) (#4403)

Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: nastasha.solomon <[email protected]>
nastasha-solomon added a commit that referenced this pull request Dec 7, 2023
@mergify @nastasha-solomon
[8.2] Document the behavior of IM rules and multi-value indicator doc…
e68a532 
…uments (backport #4326) (#4405)

Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: nastasha.solomon <[email protected]>
nastasha-solomon added a commit that referenced this pull request Dec 7, 2023
@mergify @nastasha-solomon
[8.3] Document the behavior of IM rules and multi-value indicator doc…
c76a83d 
…uments (backport #4326) (#4404)

Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: nastasha.solomon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd left review comments

@natasha-moore-elastic natasha-moore-elastic natasha-moore-elastic approved these changes

Assignees

@nastasha-solomon nastasha-solomon

Labels
Effort: Medium Issues that take moderate but not substantial time to complete Priority: Low Issues that need attention, but are not urgent Team: Detection Engine v8.2.0 v8.3.0 v8.4.0 v8.5.0 v8.6.0 v8.7.0 v8.8.0 v8.9.0 v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nastasha-solomon @rylnd @natasha-moore-elastic